You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why are both fields in VolumeSnapshotError struct optional?
// VolumeSnapshotError describes an error encountered during snapshot creation.
type VolumeSnapshotError struct {
// time is the timestamp when the error was encountered.
// +optional
Time *metav1.Time `json:"time,omitempty" protobuf:"bytes,1,opt,name=time"`
// message is a string detailing the encountered error during snapshot
// creation if specified.
// NOTE: message may be logged, and it should not contain sensitive
// information.
// +optional
Message *string `json:"message,omitempty" protobuf:"bytes,2,opt,name=message"`
}
This doesn't make sense IMO. Is there a value in instantiating empty error struct?
The text was updated successfully, but these errors were encountered:
You are right, ideally Time and Message should be required in this struct. However, since Volume Snapshot API is already GA, we cannot make the optional fields required.
Why are both fields in
VolumeSnapshotError
struct optional?This doesn't make sense IMO. Is there a value in instantiating empty error struct?
The text was updated successfully, but these errors were encountered: