Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit tests for default snapshot class #1211

Open
xing-yang opened this issue Nov 22, 2024 · 1 comment
Open

More unit tests for default snapshot class #1211

xing-yang opened this issue Nov 22, 2024 · 1 comment
Assignees

Comments

@xing-yang
Copy link
Collaborator

What happened:
Open this issue to track this comment from the code review:
#1210 (comment)
We need to add more unit tests.

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@gnufied
Copy link
Contributor

gnufied commented Dec 3, 2024

Also can we add unit test for this scenario?

  1. Create a volumegroupsnapshotclass.
  2. Create one or more PVCs that use volumes.
  3. Take snapshot of those PVCs via volumegroupsnapshot
  4. Expect everything to work. Expect volumesnapshot objects to be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants