-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nil check for groupSnapshotContent in deleteCSIGroupSnapshotOperaion and unit tests #1152
base: master
Are you sure you want to change the base?
Conversation
Hi @manishym. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
Can you please rebase? |
…tion and unit tests - Add a check to ensure `groupSnapshotContent` is not nil in `deleteCSIGroupSnapshotOperation` to prevent panics. - Enhance error handling for missing `SnapshotHandle` in `VolumeSnapshotContent` objects during deletion. - Create initial unit tests in `groupsnapshot_helper_test.go` to cover cases where `groupSnapshotContent` is nil or incomplete. Signed-off-by: Manish <[email protected]>
5f04b1b
to
9752e2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manishym, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@manishym can you please rebase the PR |
groupSnapshotContent
is not nil indeleteCSIGroupSnapshotOperation
to prevent panics.SnapshotHandle
inVolumeSnapshotContent
objects during deletion.groupsnapshot_helper_test.go
to cover cases wheregroupSnapshotContent
is nil or incomplete.What type of PR is this?
What this PR does / why we need it:
Before fix:
After fix:
Which issue(s) this PR fixes:
Fixes #1123
Special notes for your reviewer:
Does this PR introduce a user-facing change?: