-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need standard parameter keys for VolumeGroupSnapshotClass parameters #1122
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
We should add a document similar to this one: https://kubernetes-csi.github.io/docs/secrets-and-credentials-volume-snapshot-class.html |
One thing missing is this one: https://github.com/kubernetes-csi/external-snapshotter/blob/master/pkg/utils/util.go#L65-L66 |
What happened:
There appears to not be any documentation on volume group specific parameters that could be passed in the VolumeGroupSnapshotClass. I have found that I can put any parameter I want in and it will be passed into the CreateVolumeGroupSnapshotRequest which works for my use case (e.g. to pass in storage device Secret and Namespace), however I would think there would be some standard parameter keys for passing in a secret name and namespace?
What you expected to happen:
I would expect some standard parameter keys for VolumeGroupSnapshotClass parameters specifically for secret name and namespace. I could not find documentation on this.
How to reproduce it:
Anything else we need to know?:
looking at the source code, I noticed that snapshot.storage.kubernetes.io/deletion-secret-name: or snapshot.storage.kubernetes.io/deletion-secret-namespace are looked for and passed to CreateVolumeGroupSnapshot requests if these parameters are specified in the VolumeGroupSnapshotClass .... These parameter key names seem confusing to me given they make their way into a CreateVolumeGroupSnapshot request, also the key name is not like the other key names in terms of naming convention.
Environment:
kubectl version
): 1.30.1uname -a
):The text was updated successfully, but these errors were encountered: