Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need standard parameter keys for VolumeGroupSnapshotClass parameters #1122

Open
jmccormick2001 opened this issue Jul 25, 2024 · 4 comments
Open

Comments

@jmccormick2001
Copy link

What happened:
There appears to not be any documentation on volume group specific parameters that could be passed in the VolumeGroupSnapshotClass. I have found that I can put any parameter I want in and it will be passed into the CreateVolumeGroupSnapshotRequest which works for my use case (e.g. to pass in storage device Secret and Namespace), however I would think there would be some standard parameter keys for passing in a secret name and namespace?

What you expected to happen:

I would expect some standard parameter keys for VolumeGroupSnapshotClass parameters specifically for secret name and namespace. I could not find documentation on this.

How to reproduce it:

Anything else we need to know?:
looking at the source code, I noticed that snapshot.storage.kubernetes.io/deletion-secret-name: or snapshot.storage.kubernetes.io/deletion-secret-namespace are looked for and passed to CreateVolumeGroupSnapshot requests if these parameters are specified in the VolumeGroupSnapshotClass .... These parameter key names seem confusing to me given they make their way into a CreateVolumeGroupSnapshot request, also the key name is not like the other key names in terms of naming convention.

Environment:

  • Driver version: 1.9.0
  • Kubernetes version (use kubectl version): 1.30.1
  • OS (e.g. from /etc/os-release): ubuntu jammy
  • Kernel (e.g. uname -a):
  • Install tools: k3s
  • Others:
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
@xing-yang
Copy link
Collaborator

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2024
@xing-yang
Copy link
Collaborator

@xing-yang
Copy link
Collaborator

One thing missing is this one: https://github.com/kubernetes-csi/external-snapshotter/blob/master/pkg/utils/util.go#L65-L66
We should add a similar one for GetVolumeGroupSnapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants