-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow some PVC annotations to be passed to CreateVolume() #535
Conversation
Add an option to the external-provisioner sidecar to pass a subset of the PVC annotations to CreateVolume(). Using a vendor or administrator-specified prefix, PVC annotations matching that prefix will be included alongside storage class parameters. This avoids conflicts between storage class parameters and PVC annotations by only allowing annotations with a speficic prefix to be passed through. Vendors must use vendor-specific prefixes to avoid conflicts between CSI plugins. The options defaults to disabled, and requires vendor support in the CSI plugin to enable. Administrators may override this and disable it by modifying the sidecar container to not pass the option.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bswartz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bswartz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold We did get lots of requests for this feature, so I think this will be very useful. However, we discussed at the SIG-Storage meeting on 12/3 and decided that this will still break portability. Putting this on hold for now. Need further discussions to come up with a better solution. |
@bswartz: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Add an option to the external-provisioner sidecar to pass a subset of the
PVC annotations to CreateVolume(). Using a vendor or administrator-specified
prefix, PVC annotations matching that prefix will be included alongside
storage class parameters.
This avoids conflicts between storage class parameters and PVC annotations
by only allowing annotations with a speficic prefix to be passed through.
Vendors must use vendor-specific prefixes to avoid conflicts between CSI
plugins.
The options defaults to disabled, and requires vendor support in the CSI
plugin to enable. Administrators may override this and disable it by
modifying the sidecar container to not pass the option.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows per-PVC options to be passed through in a way that minimizes the problematic reasons we've rejected similar proposals in the past.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: