Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some PVC annotations to be passed to CreateVolume() #535

Closed
wants to merge 1 commit into from

Conversation

bswartz
Copy link
Contributor

@bswartz bswartz commented Dec 3, 2020

Add an option to the external-provisioner sidecar to pass a subset of the
PVC annotations to CreateVolume(). Using a vendor or administrator-specified
prefix, PVC annotations matching that prefix will be included alongside
storage class parameters.

This avoids conflicts between storage class parameters and PVC annotations
by only allowing annotations with a speficic prefix to be passed through.
Vendors must use vendor-specific prefixes to avoid conflicts between CSI
plugins.

The options defaults to disabled, and requires vendor support in the CSI
plugin to enable. Administrators may override this and disable it by
modifying the sidecar container to not pass the option.

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows per-PVC options to be passed through in a way that minimizes the problematic reasons we've rejected similar proposals in the past.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

TBD

Add an option to the external-provisioner sidecar to pass a subset of the
PVC annotations to CreateVolume(). Using a vendor or administrator-specified
prefix, PVC annotations matching that prefix will be included alongside
storage class parameters.

This avoids conflicts between storage class parameters and PVC annotations
by only allowing annotations with a speficic prefix to be passed through.
Vendors must use vendor-specific prefixes to avoid conflicts between CSI
plugins.

The options defaults to disabled, and requires vendor support in the CSI
plugin to enable. Administrators may override this and disable it by
modifying the sidecar container to not pass the option.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bswartz
To complete the pull request process, please assign jsafrane after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

@bswartz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-provisioner-unit 973b9a9 link /test pull-kubernetes-csi-external-provisioner-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xing-yang
Copy link
Contributor

/hold

We did get lots of requests for this feature, so I think this will be very useful. However, we discussed at the SIG-Storage meeting on 12/3 and decided that this will still break portability. Putting this on hold for now. Need further discussions to come up with a better solution.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 6, 2020
@k8s-ci-robot
Copy link
Contributor

@bswartz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2021
@bswartz bswartz closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants