-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 2.1 #199
Prepare release 2.1 #199
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
13a46b5
to
c225717
Compare
cc @msau42, PTAL |
README.md
Outdated
@@ -21,7 +21,7 @@ This information reflects the head of this branch. | |||
|
|||
| Compatible with CSI Version | Container Image | Min K8s Version | | |||
| ------------------------------------------------------------------------------------------ | ----------------------------| --------------- | | |||
| [CSI Spec v1.0.0](https://github.com/container-storage-interface/spec/releases/tag/v1.0.0) | quay.io/k8scsi/csi-attacher | 1.15 | | |||
| [CSI Spec v1.2.0](https://github.com/container-storage-interface/spec/releases/tag/v1.2.0) | quay.io/k8scsi/csi-attacher | 1.15 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add recommended k8s version column since migration is beta in 1.17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added recommended version
@@ -32,7 +32,7 @@ The following table reflects the head of this branch. | |||
| Feature | Status | Default | Description | | |||
| ------------- | ------- | ------- | --------------------------------------------------------------------------------------------- | | |||
| CSINode* | Beta | On | external-attacher uses the CSINode object to get the driver's node name instead of the Node annotation. | | |||
| CSIMigration* | Alpha | On | [Migrating in-tree volume plugins to CSI](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration). | | |||
| CSIMigration* | Beta | On | [Migrating in-tree volume plugins to CSI](https://kubernetes.io/docs/concepts/storage/volumes/#csi-migration). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSINode is GA now, but we still use beta object for backwards compatibility. How do you want to note it? Or can we remove it altogether? Our min version is 1.15 which means that it should not be falling back on node annotation anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we ever removed storage.k8s.io/v1beta1
? IMO we've always added new objects there (+v1alpha1) and we do not deprecate / remove it. We can keep using it and move to v1 in the next release, bumping just min. k8s version.
We should not use the node annotation, I filed #203.
c7f026d
to
a78a8cf
Compare
Added recommended version + Saad's metrics to CHANGELOG |
/lgtm |
d24254f6 Merge pull request kubernetes-csi#202 from xing-yang/kind_0.14.0 0faa3fc7 Update to Kind v0.14.0 images ef4e1b2b Merge pull request kubernetes-csi#201 from xing-yang/add_1.24_image 4ddce251 Add 1.24 Kind image 7fe51491 Merge pull request kubernetes-csi#200 from pohly/bump-kubernetes-version 70915a8e prow.sh: update snapshotter version 31a3f38b Merge pull request kubernetes-csi#199 from pohly/bump-kubernetes-version 7577454a prow.sh: bump Kubernetes to v1.22.0 git-subtree-dir: release-tools git-subtree-split: d24254f6aa780bb6ba36a946973ee01df5633f6b
/kind documentation
Update README and CHANGELOG for release 2.1