-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing supports for kubernetes client stable and gold #166
Comments
@mbohlool what does "proto encoding" mean? |
@lavalamp should know more about this, but I assume it means we encode the request body with proto instead of json. |
Correct, request & response bodies. Here's an example proto file: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/apps/v1beta1/generated.proto You may not be able to determine the proto encoding from the OpenAPI spec--it'll be interesting to see you try to support these protos in a non-go language... Also the levels were chosen so that Silver was a perfectly acceptable sort of client to have, so it's not bad to be Silver :) It's just that if someone is going to write a high-bandwidth controller of some sort, proto is a lot more efficient. |
@lavalamp what does "Generated Examples" mean in that doc? Does that mean that you have example code for the library? or that it is generated from something? |
Sorry if it's too obious, but does proto mean using this library: https://github.com/google/protobuf/tree/master/python ? |
I looked briefly. The library needs protoc to be installed using other
means than pip. If prefer other python only solutions but if that is only
option, we should take it. Basically we want to be able to talk proto with
api server instead of json. That could include using generated proto
messages in k8s main repo. This needs some investigation before
implementation.
…On Jun 7, 2017 5:09 AM, "Sergi Almacellas Abellana" < ***@***.***> wrote:
Sorry if it's too obious, but does proto mean using this library:
https://github.com/google/protobuf/tree/master/python ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#166 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABic4IcM8NiAlEK3zjc7lq-MWdjDBlAeks5sBpL6gaJpZM4MvaP_>
.
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Just to clarify, does this mean port forwarding is not currently supported? |
/remove-lifecycle rotten |
That is correct. Port forwarding is not yet supported on this client. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/lifecycle frozen |
port-forward call still not supported in python-client now? |
Is there a record of documented users of the library? i.e. A markdown file or something. I'd like to add to it if so. |
Hey guys, any idea on how the attach / port-forward item is looking? |
according to new kubernetes client guidelines python client is beta support and has silver capabilities. We are almost there to have gold capabilities and stable support. missing parts are:
Gold:
Stable:
The text was updated successfully, but these errors were encountered: