Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing supports for kubernetes client stable and gold #166

Open
7 tasks
mbohlool opened this issue Mar 31, 2017 · 16 comments
Open
7 tasks

Add missing supports for kubernetes client stable and gold #166

mbohlool opened this issue Mar 31, 2017 · 16 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mbohlool
Copy link
Contributor

mbohlool commented Mar 31, 2017

according to new kubernetes client guidelines python client is beta support and has silver capabilities. We are almost there to have gold capabilities and stable support. missing parts are:

Gold:

Stable:

  • N documented users of the library
  • Support level documented per-platform
  • Deprecation policy (backwards compatibility guarantees documented)
  • Release process well documented
@mbohlool mbohlool added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 31, 2017
@dims
Copy link
Collaborator

dims commented Mar 31, 2017

@mbohlool what does "proto encoding" mean?

@mbohlool
Copy link
Contributor Author

@lavalamp should know more about this, but I assume it means we encode the request body with proto instead of json.

@lavalamp
Copy link
Member

Correct, request & response bodies. Here's an example proto file: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/apps/v1beta1/generated.proto

You may not be able to determine the proto encoding from the OpenAPI spec--it'll be interesting to see you try to support these protos in a non-go language...

Also the levels were chosen so that Silver was a perfectly acceptable sort of client to have, so it's not bad to be Silver :)

It's just that if someone is going to write a high-bandwidth controller of some sort, proto is a lot more efficient.

@brendandburns
Copy link
Contributor

@lavalamp what does "Generated Examples" mean in that doc? Does that mean that you have example code for the library? or that it is generated from something?

@pokoli
Copy link

pokoli commented Jun 7, 2017

Sorry if it's too obious, but does proto mean using this library: https://github.com/google/protobuf/tree/master/python ?

@mbohlool
Copy link
Contributor Author

mbohlool commented Jun 8, 2017 via email

@roycaihw roycaihw added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 7, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2019
@BenElgar
Copy link

Just to clarify, does this mean port forwarding is not currently supported?

@micw523
Copy link
Contributor

micw523 commented Jun 20, 2019

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 20, 2019
@micw523
Copy link
Contributor

micw523 commented Jun 20, 2019

That is correct. Port forwarding is not yet supported on this client.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2019
@micw523
Copy link
Contributor

micw523 commented Sep 18, 2019

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 18, 2019
@mayu2010
Copy link

port-forward call still not supported in python-client now?

@ghost
Copy link

ghost commented Feb 28, 2020

Is there a record of documented users of the library? i.e. A markdown file or something. I'd like to add to it if so.

@KnifeyMoloko
Copy link

Hey guys, any idea on how the attach / port-forward item is looking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests