aws-iam-authenticator not found when kube config contains exec env variables

[michaelgeorgeattard]

I am getting an aws-iam-authenticator not found error with the following kube config snippet:

users:
- name: arn:aws:eks:eu-west-1:111111111111:cluster/foo
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      args:
      - token
      - -i
      - foo
      command: aws-iam-authenticator
      env:
      - name: AWS_PROFILE
        value: bar

Looks like this is due to a bug in exec_auth.ts:

javascript/src/exec_auth.ts

Line 60 in e5ec945

const result = shell.exec(cmd, opts);

shelljs.exec second parameter is defined below:

https://github.com/shelljs/shelljs#execcommand--options--callback

Maybe this could be solved using something like:

exec.env.forEach((elt) => {
  shell.env[elt.name] = elt.value;
});

[brendandburns]

The environment variable setup here:

https://github.com/kubernetes-client/javascript/blob/master/src/exec_auth.ts#L58

Can you add more details about the bug?

Thanks!

[brendandburns]

And I think that the error indicates that the aws-iam-authenticator is not in your ${PATH}

[michaelgeorgeattard]

First of all, excuse me for repeating myself, but I think I didn't get the point across in my previous comment:

The bug is probably in the way shell.exec is called.

Transforming the below:

const result = shell.exec(cmd, opts); 

Into:

const result = shell.exec(cmd);

Allows shelljs to "find" aws-iam-authenticator.

Environment variables should NOT be passed as the second variable to shell.exec but rather as below:

https://github.com/shelljs/shelljs#execcommand--options--callback

[michaelgeorgeattard]

Also to replicate add env variables to kube config as below:

users:
- name: arn:aws:eks:eu-west-1:111111111111:cluster/foo
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      args:
      - token
      - -i
      - foo
      command: aws-iam-authenticator
      env: # add this part
      - name: foo
        value: bar

[brendandburns]

Ah, ok, I think I see. The problem is that we should duplicate the existing environment variables before we pass them to exec.

As far as I can read the docs, the way that we are passing environment variables is correct, but because there is no PATH present in the env it isn't present.

I'm pretty sure I see the right way to fix this, I will send a PR.

[brendandburns]

Sent a PR with the fix.