Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-cluster config builder does not work properly in an ipv6 cluster #839

Closed
liggitt opened this issue Dec 19, 2019 · 2 comments · Fixed by #840
Closed

In-cluster config builder does not work properly in an ipv6 cluster #839

liggitt opened this issue Dec 19, 2019 · 2 comments · Fixed by #840

Comments

@liggitt
Copy link

liggitt commented Dec 19, 2019

final String host = System.getenv(ENV_SERVICE_HOST);
final String port = System.getenv(ENV_SERVICE_PORT);
builder.setBasePath("https://" + host + ":" + port);

assumes a DNS name or ipv4 address... it does not work correctly with an ipv6 address (the ipv6 host must be wrapped in brackets)

@liggitt
Copy link
Author

liggitt commented Dec 19, 2019

cc @thockin

@brendandburns
Copy link
Contributor

Thanks for reporting, will send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants