V1RollingUpdateDaemonSet maxUnavailable is 'String' but API specifies 'IntOrString'

[bcoughlan]

V1beta2RollingUpdateDaemonSet has IntOrString maxUnavailable but V1RollingUpdateDaemonSet has String maxUnavailable, even though the swagger.json specifies it as an IntOrString.

This causes an issue that when trying to use the integer form for maxUnavailable, because the API assumes that if it is a string then it should be treated as a percentage.

spec.updateStrategy.rollingUpdate.maxUnavailable: Invalid value: intstr.IntOrString{Type:1, IntVal:0, StrVal:\"1\"}: a valid percent string must be a numeric string followed by an ending '%'

[brendandburns]

This is weird. Looking at the Swagger I don't see any reason why this should be true, and yet there it is... This may be a bug in the code generator, we'll have to investigate more.

[yue9944882]

    "io.k8s.api.apps.v1.RollingUpdateDaemonSet": {
      "description": "Spec to control the desired behavior of daemon set rolling update.",
      "type": "object",
      "properties": {
        "maxUnavailable": {
          "description": "The maximum number of DaemonSet pods that can be unavailable during the update. Value can be an absolute number (ex: 5) or a percentage of total number of DaemonSet pods at the start of the update (ex: 10%). Absolute number is calculated from percentage by rounding up. This cannot be 0. Default value is 1. Example: when this is set to 30%, at most 30% of the total number of nodes that should be running the daemon pod (i.e. status.desiredNumberScheduled) can have their pods stopped for an update at any given time. The update starts by stopping at most 30% of those DaemonSet pods and then brings up new DaemonSet pods in their place. Once the new pods are available, it then proceeds onto other DaemonSet pods, thus ensuring that at least 70% of original number of DaemonSet pods are available at all times during the update.",
          "$ref": "#/definitions/io.k8s.apimachinery.pkg.util.intstr.IntOrString"
        }
      }
    },

sth must be wrong w/ the code-generator, the openapi spec from kubernetes cluster is correct.

[yue9944882]

let me check if migrating to openapi-generator will solve the issue..

UPDATE: the openapi-generator doesn't actually solve this..

[bcoughlan]

FWIW, I tried generating the code using the instructions in the README (even after deleting the old V1RollingUpdateDaemonSet.java file) with the latest release-1.14, and it still generated it as type String. So it's probably not related to any issues around incremental building or caching.

[yue9944882]

UPDATE: OpenAPITools/openapi-generator#4182 will be fixing this

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[GeneralKenobi]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[brendandburns]

/lifecycle frozen

[brendandburns]

This was fixed a while ago, but the issue wasn't closed.

https://github.com/kubernetes-client/java/blob/master/kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1RollingUpdateDaemonSet.java#L52

[huhu-sky]

{
	"kind": "Status",
	"apiVersion": "v1",
	"metadata": {},
	"status": "Failure",
	"message": "Deployment.apps \"ingress-gateway-test\" is invalid: [spec.strategy.rollingUpdate.maxUnavailable: Invalid value: intstr.IntOrString{Type:1, IntVal:0, StrVal:\"1\"}: a valid percent string must be a numeric string followed by an ending '%' (e.g. '1%',  or '93%', regex used for validation is '[0-9]+%'), spec.strategy.rollingUpdate.maxSurge: Invalid value: intstr.IntOrString{Type:1, IntVal:0, StrVal:\"1\"}: a valid percent string must be a numeric string followed by an ending '%' (e.g. '1%',  or '93%', regex used for validation is '[0-9]+%')]",
	"reason": "Invalid",
	"details": {
		"name": "ingress-gateway-test",
		"group": "apps",
		"kind": "Deployment",
		"causes": [
			{
				"reason": "FieldValueInvalid",
				"message": "Invalid value: intstr.IntOrString{Type:1, IntVal:0, StrVal:\"1\"}: a valid percent string must be a numeric string followed by an ending '%' (e.g. '1%',  or '93%', regex used for validation is '[0-9]+%')",
				"field": "spec.strategy.rollingUpdate.maxUnavailable"
			},
			{
				"reason": "FieldValueInvalid",
				"message": "Invalid value: intstr.IntOrString{Type:1, IntVal:0, StrVal:\"1\"}: a valid percent string must be a numeric string followed by an ending '%' (e.g. '1%',  or '93%', regex used for validation is '[0-9]+%')",
				"field": "spec.strategy.rollingUpdate.maxSurge"
			}
		]
	},
	"code": 422
}

I have the same error with 5.0.0, so which version i can use to solve this problem, Thanks;

[chengdonglin]

this reason is because the k8s use the gson, but you app use the other json package, which can not convert the intOrString type, so you should define the json util to hanlde the intOrString type