Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose release: need release with fix for pod exec WebSockets bug #210

Closed
rjeberhard opened this issue Mar 14, 2018 · 4 comments
Closed

Comments

@rjeberhard
Copy link
Contributor

@brendandburns,

Any chance we could please get a 1.0.0-beta3 release including the fix for #180? While we can test with local changes, since we're also an open-source project, I can't commit a modified version of WebSockets.java to our repository. Thanks in advance.

Any word on what the release roadmap will be?

@brendandburns
Copy link
Contributor

Sure, I can cut a new release this weekend...

@rjeberhard
Copy link
Contributor Author

Thanks! I appreciate it. Just a heads-up, I had a PR for Exec that would support reading non-zero exit codes and Exec$ExecProcess.waitFor(long, TimeUnit); however, I've temporarily retracted it because the API server always returns 400 bad request when stdin=false. I need to find someone who understands the server-side validation.

@greglanthier
Copy link
Contributor

I think a problem I stumbled on this evening with port-forwarding (see this comment) might be resolved by PR #202. I'd be keen to try out a new release including PR #202 when its available.

@brendandburns
Copy link
Contributor

Ok, this has been staged out to sonatype. It may take a little while before it is replicated to maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants