Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericClient.WatchAsync/WatchNamespacedAsync ignore method parameters #1499

Closed
alex-zyl opened this issue Jan 15, 2024 · 1 comment · Fixed by #1500
Closed

GenericClient.WatchAsync/WatchNamespacedAsync ignore method parameters #1499

alex-zyl opened this issue Jan 15, 2024 · 1 comment · Fixed by #1500

Comments

@alex-zyl
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Kubernetes C# SDK Client Version
13.0.1

Server Kubernetes Version
1.23.0

Dotnet Runtime Version
net8

To Reproduce

Expected behavior
WatchAsync
WatchNamespacedAsync
Both methods accept onError callback and cancellation token as parameters but they're not later passed into underlying watcher

Expected

return respTask.WatchAsync<T, T>(onError, cancellationToken);

KubeConfig
not relevant

Where do you run your app with Kubernetes SDK (please complete the following information):
not relevant

Additional context

@tg123
Copy link
Member

tg123 commented Jan 15, 2024

good catch, could you please send a pr to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants