Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: extract credentials from awscli config #149

Closed
3 tasks
kdomanski opened this issue Jan 2, 2019 · 1 comment · Fixed by #156
Closed
3 tasks

AWS: extract credentials from awscli config #149

kdomanski opened this issue Jan 2, 2019 · 1 comment · Fixed by #156
Assignees
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@kdomanski
Copy link
Contributor

kdomanski commented Jan 2, 2019

Currently the AWS code of KubeOne expects the AWS credentials (e.g. for the machine controller) to be contained within the AWS_* environmental variables and picks them up using custom code. A user is likely to have these credentials in their AWS CLI config file instead, especially since most provisioning tools, e.g. Terraform or Vagrant are perfectly capable of accessing these - therefore KubeOne should also have this capacity, and it should follow typical conventions e.g. for picking the profile.

Acceptance criteria:

  • for AWS clusters KubeOne first attempts to fetch env-var-based credentials using github.com/aws/aws-sdk-go/aws/credentials.NewEnvCredentials()
  • If that fails, it should attempt to extract them from the config file's current profile using github.com/aws/aws-sdk-go/aws/credentials.NewSharedCredentials("", "")
  • if that fails too, the failure should be immediate and KubeOne should not attempt to deploy machine-controller with empty credentials
@xmudrii
Copy link
Member

xmudrii commented Jan 7, 2019

I want to give this a try.

/assign
/lifecycle active

@kubermatic-bot kubermatic-bot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants