Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shoutrrr/slack: missing channel property #390

Closed
evenh opened this issue Jun 9, 2021 · 6 comments
Closed

shoutrrr/slack: missing channel property #390

evenh opened this issue Jun 9, 2021 · 6 comments

Comments

@evenh
Copy link

evenh commented Jun 9, 2021

After looking at the release notes for 1.7.0, I found a breaking change (for our use case). If opting in to the use of shoutrrr, the ability to override the Slack channel has gone away (unsupported in shoutrrr). I know that currently both modes of notifications (static Slack implementation + shoutrrr) exists, but the writing on the walls indicates that the former will be dropped in a future release.

I have opened a PR to fix this upstream in shoutrrr: containrrr/shoutrrr#173

@dholbach
Copy link
Member

@atighineanu Do you know anything about this?

@atighineanu
Copy link
Contributor

@atighineanu Do you know anything about this?

Assign me to this pls. On it.

@atighineanu
Copy link
Contributor

I haven't tested the channel properties on any of the services, to be honest. Not many did in fact use that level of details (that I know, at least).

@evrardjp
Copy link
Collaborator

evrardjp commented Jul 28, 2021

Did you see the change in containrrr/shoutrrr#179 ?
Were you using channel properties for other things than icons?

I am afraid holding onto future removed features is not a good way forward... Shoutrrr seems to be ahead of the game, and it makes sense for us to use it, don't you think? What would be the alternative, if things aren't okay with shoutrrr (need more channel properties)?

@evenh
Copy link
Author

evenh commented Jul 28, 2021

The number one feature for me was to override channel name, since it meant only interacting with one Slack webhook token.

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants