Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Fix the warnings reported by goreportcard.com #394

Closed
gaocegege opened this issue Feb 16, 2018 · 6 comments
Closed

[enhancement] Fix the warnings reported by goreportcard.com #394

gaocegege opened this issue Feb 16, 2018 · 6 comments
Labels
difficulty/low good first issue lifecycle/stale priority/p3

Comments

@gaocegege
Copy link
Member

Now our code does not follow golang style well, it has gofmt and golint errors: https://goreportcard.com/report/github.com/kubeflow/tf-operator

Please help us to fix them. This issue is open for new contributors and it will help you to get involved in the development of our project :)
@gaocegege gaocegege changed the title [enhancement] Fix the warnings reported by go report [enhancement] Fix the warnings reported by goreportcard.com Feb 16, 2018
@kayush2O6
Copy link
Contributor

I will start working on it. I'll let you when done.

@gaocegege
Copy link
Member Author

@AK-ayush 👌 Just go ahead

@kayush2O6
Copy link
Contributor

@gaocegege I have fixed some warnings. I have generated pull request #396 just to make sure that nothing is broken till now.

@kayush2O6 kayush2O6 mentioned this issue Feb 20, 2018
Closed
@kayush2O6 kayush2O6 mentioned this issue Mar 19, 2018
Closed
@gaocegege
Copy link
Member Author

Close by #486

@gaocegege
Copy link
Member Author

It seems that there still be some errors, so I reopen it and welcome to fix errors.

@gaocegege gaocegege reopened this Mar 23, 2018
@stale
Copy link

stale bot commented Apr 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/low good first issue lifecycle/stale priority/p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaocegege @kayush2O6