Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releaser incorrectly tags images as "dirty" #321

Closed
jlewi opened this issue Jan 17, 2018 · 4 comments
Closed

Releaser incorrectly tags images as "dirty" #321

jlewi opened this issue Jan 17, 2018 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 17, 2018

The releaser is tagging our images as dirty; e.g.

gcr.io/tf-on-k8s-dogfood/tf_operator:v20180117-04425d9-dirty-e3b0c44

Probably because we modify some files in the git source tree as part of a build.

We should fix this.

@jlewi jlewi changed the title Releaser tags images as "dirty" Releaser incorrectly tags images as "dirty" Jan 17, 2018
@jlewi jlewi added this to the Kubecon Europe milestone Jan 17, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Jan 25, 2018

See #339 for discussion about how we want to start tagging our releases.

@jose5918
Copy link
Contributor

jose5918 commented Feb 1, 2018

@jlewi Mind if I take this? I found this was being tagged as dirty as a result of glide install. Making an adjustment to how we check modified files like this: git ls-files *[^vendor/*] --modified or git ls-files --modified | grep -v ^vendor should make it stop tagging as dirty. Does that seem like a valid solution?

Also I haven't tried with airflow or anything but the earliest release I see tagged as dirty gs://tf-on-k8s-dogfood-releases/v20171218-c8bcb9d-dirty-e3b0c44/ matches the pr that added vendor #222

@jlewi
Copy link
Contributor Author

jlewi commented Feb 1, 2018

That would be great thanks.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 7, 2018

This is obsolete since we are moving to using an Argo workflow to build images and that doesn't appear to have this problem.

@jlewi jlewi closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants