Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Client Generation for Java, Python #167

Closed
jlewi opened this issue Nov 21, 2017 · 21 comments · Fixed by #1103
Closed

OpenAPI Client Generation for Java, Python #167

jlewi opened this issue Nov 21, 2017 · 21 comments · Fixed by #1103

Comments

@jlewi
Copy link
Contributor

jlewi commented Nov 21, 2017

Should we create a client library for Python?

How much of the client library could be autogenerated (e.g. using Swagger?).

The motivation for Python is that Python is the most common way people write TensorFlow programs. A Python client library providing higher level functions (e.g. wait for job) would make it easier to use TfJob in Juptyer environments. It would also be useful for our test infrastructure.

@foxish
Copy link

foxish commented Dec 1, 2017

cc/ @pwittrock who was recently discussing generation of openapi from CRDs.

@gaocegege
Copy link
Member

Ref #577

@gaocegege gaocegege changed the title Client library for Python OpenAPI Client Generation for Java, Python Jul 4, 2018
@gaocegege
Copy link
Member

Ref kubernetes-client/gen#59

@gaocegege
Copy link
Member

The issue is a little difficult and I am not sure if we could implement it. While ppl from alibaba and mogujie ask me if we could support it in 0.3. Thus I just added it to 0.3

@gaocegege
Copy link
Member

gaocegege commented Jul 6, 2018

@jlewi

@jetmuffin from Alibaba contributes the Java client for tfjob, while we think it should not be in this repository. Then we decided to palce it in https://github.com/kubeflow-incubator/tfjob-java-client. If the community could create a repository for it we could move it in the org.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 30, 2018

I think there is an issue to move this into the kubeflow org. I think it's better to I incubate things in our existing org for now.

There's a cost to maintaining multiple GitHub orgs that we should try to avoid until necessary.

@gaocegege
Copy link
Member

Sure, @jetmuffin will help us to migrate it to kubeflow org. While I think it is hard to implement it in 0.3

@chrisheecho
Copy link

why does this have 2 difficulties? which is it hard or medium? I would lean on hard just in case but wanted to ask why this has both @gaocegege ?

@gaocegege
Copy link
Member

between medium and hard, IMO

@chrisheecho
Copy link

haha great, can I propose to just make it hard so that we err on the safer side? :D

@gaocegege
Copy link
Member

Sure, LGTM

@jlewi
Copy link
Contributor Author

jlewi commented Oct 25, 2018

/priority p2

@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
@jlewi jlewi removed this from the 0.4.0 milestone Feb 4, 2019
@jlewi jlewi removed the priority/p3 label Feb 4, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Feb 4, 2019

@johnugeorge @richardsliu @gaocegege Should we try to do this for 0.5?

@richardsliu
Copy link
Contributor

Moving this out of 0.5.

@jlewi
Copy link
Contributor Author

jlewi commented May 17, 2019

@swiftdiaries Did this for Argo
argoproj/argo-workflows#732

@richardsliu
Copy link
Contributor

@johnugeorge Should we try to do this for v1.0?

@gaocegege
Copy link
Member

Is there anyone working on this issue?

@jlewi
Copy link
Contributor Author

jlewi commented Nov 4, 2019

I don't think anyone has picked this up.
It would be good to do this for 1.0.

@jinchihe
Copy link
Member

jinchihe commented Dec 4, 2019

@jlewi @gaocegege @richardsliu Totally agree. This is really import for kubeflow e2e user case, user would like to create tfjobs with Python SDK via Notebooks.
I will try to implement this. I implemented the kfserving SDK by this way (openapi -> Sawgger -> SDK). Thanks.

@johnugeorge
Copy link
Member

Can you please add it for pytorchjobs too?

@jinchihe
Copy link
Member

jinchihe commented Dec 5, 2019

Can you please add it for pytorchjobs too?

@johnugeorge Of couse, will add that later, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants