-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI Client Generation for Java, Python #167
Comments
cc/ @pwittrock who was recently discussing generation of openapi from CRDs. |
Ref #577 |
The issue is a little difficult and I am not sure if we could implement it. While ppl from alibaba and mogujie ask me if we could support it in 0.3. Thus I just added it to 0.3 |
@jetmuffin from Alibaba contributes the Java client for tfjob, while we think it should not be in this repository. Then we decided to palce it in https://github.com/kubeflow-incubator/tfjob-java-client. If the community could create a repository for it we could move it in the org. |
I think there is an issue to move this into the kubeflow org. I think it's better to I incubate things in our existing org for now. There's a cost to maintaining multiple GitHub orgs that we should try to avoid until necessary. |
Sure, @jetmuffin will help us to migrate it to kubeflow org. While I think it is hard to implement it in 0.3 |
why does this have 2 difficulties? which is it hard or medium? I would lean on hard just in case but wanted to ask why this has both @gaocegege ? |
between medium and hard, IMO |
haha great, can I propose to just make it hard so that we err on the safer side? :D |
Sure, LGTM |
/priority p2 |
@johnugeorge @richardsliu @gaocegege Should we try to do this for 0.5? |
Moving this out of 0.5. |
@swiftdiaries Did this for Argo |
@johnugeorge Should we try to do this for v1.0? |
Is there anyone working on this issue? |
I don't think anyone has picked this up. |
@jlewi @gaocegege @richardsliu Totally agree. This is really import for kubeflow e2e user case, user would like to create tfjobs with Python SDK via Notebooks. |
Can you please add it for pytorchjobs too? |
@johnugeorge Of couse, will add that later, thanks. |
Should we create a client library for Python?
How much of the client library could be autogenerated (e.g. using Swagger?).
The motivation for Python is that Python is the most common way people write TensorFlow programs. A Python client library providing higher level functions (e.g. wait for job) would make it easier to use TfJob in Juptyer environments. It would also be useful for our test infrastructure.
The text was updated successfully, but these errors were encountered: