Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support SchedulingPolicy in PyTorchJob #1414

Closed
gaocegege opened this issue Sep 22, 2021 · 2 comments
Closed

[feature] Support SchedulingPolicy in PyTorchJob #1414

gaocegege opened this issue Sep 22, 2021 · 2 comments

Comments

@gaocegege
Copy link
Member

https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v1/pytorch/pytorchjob_controller.go#L164

SchedulingPolicy is not supported in PyTorchJob, we should implement it just like TFJob.

@Jeffwan
Copy link
Member

Jeffwan commented Sep 22, 2021

I think It's due to some migration issue. The support should be easy, we just need to use job.spec.runPolicy directly as the argument for reconcileJobs because all jobs are migrated to use commonv1.RunPolicy now

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants