Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge/credit contributors from other training operator repos #1357

Closed
terrytangyuan opened this issue Aug 14, 2021 · 4 comments · Fixed by #1422
Closed

Acknowledge/credit contributors from other training operator repos #1357

terrytangyuan opened this issue Aug 14, 2021 · 4 comments · Fixed by #1422
Assignees

Comments

@terrytangyuan
Copy link
Member

There are many contributors in other training operator repos that are not part of this repo's history. We should consider summarizing their contributions based on GitHub contributions graph for each individual repos.

@kubeflow/wg-training-leads

@Jeffwan
Copy link
Member

Jeffwan commented Aug 14, 2021

@terrytangyuan Totally agree. Is there an easier way to do that? Do we need some tools to populate the contributions?

@terrytangyuan
Copy link
Member Author

terrytangyuan commented Aug 14, 2021

If there's a way to migrate those commits to this repo without affecting the project, it would be really great.

If not, we can just use GitHub API to summarize the contributions (number of commits, additions, and deletions, link to the list of commits, PRs reviewed, issue discussions involved, etc.). I had a tiny project that does something similar but it's in R and I haven't worked on it for a while. If others have any recommended tools, please comment here as well.

@terrytangyuan
Copy link
Member Author

To simplify this, I am thinking about just adding an acknowledgement section in the README that links to the contributors graph in each of the original repos as well as the major contributors and maintainers. What do you think? Let me know what I might be missing in the meantime and I'll get to this soon.

@gaocegege
Copy link
Member

I am thinking about just adding an acknowledgement section in the README

SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants