From dd3a7a6524b57a6327bd61eec8289204c135b5a8 Mon Sep 17 00:00:00 2001 From: Andrey Velichkevich Date: Thu, 28 Nov 2024 21:58:42 +0000 Subject: [PATCH] Fix type for lora_dropout Signed-off-by: Andrey Velichkevich --- hack/python-sdk-v2/gen-sdk.sh | 4 ---- sdk_v2/kubeflow/training/types/types.py | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hack/python-sdk-v2/gen-sdk.sh b/hack/python-sdk-v2/gen-sdk.sh index 97cf32fc91..4203287efd 100755 --- a/hack/python-sdk-v2/gen-sdk.sh +++ b/hack/python-sdk-v2/gen-sdk.sh @@ -54,11 +54,7 @@ git clean -f ${SDK_OUTPUT_PATH}/setup.py git clean -f ${SDK_OUTPUT_PATH}/test-requirements.txt git clean -f ${SDK_OUTPUT_PATH}/tox.ini -<<<<<<< HEAD # Revert the README since it is manually created. -======= -# Revert files that are manually created. ->>>>>>> f921bbe5 (Using global prop to remove SDK tests) git checkout ${SDK_OUTPUT_PATH}/README.md git checkout ${SDK_OUTPUT_PATH}/kubeflow/training/__init__.py diff --git a/sdk_v2/kubeflow/training/types/types.py b/sdk_v2/kubeflow/training/types/types.py index 706ed7ba09..838bb84112 100644 --- a/sdk_v2/kubeflow/training/types/types.py +++ b/sdk_v2/kubeflow/training/types/types.py @@ -56,7 +56,9 @@ class LoraConfig: default=None, metadata={"help": "Lora attention dimension"} ) lora_alpha: Optional[int] = field(default=None, metadata={"help": "Lora alpha"}) - lora_dropout: Optional[int] = field(default=None, metadata={"help": "Lora dropout"}) + lora_dropout: Optional[float] = field( + default=None, metadata={"help": "Lora dropout"} + ) @dataclass