Fix bug that prevents permanent errors from causing job failure. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2017 18:12
* Code should not depend on the termination message being set to decide whether to trust exit code. This is legacy code that dependend on a script setting the termination message. But the CRD no longer uses a script to launch the TF process.
oksanabaza
pushed a commit
to oksanabaza/training-operator
that referenced
this pull request
Jan 13, 2025
Update Dockerfile.konflux for adding label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code should not depend on the termination message being set to decide
whether to trust exit code. This is legacy code that dependend on a
script setting the termination message. But the CRD no longer uses
a script to launch the TF process.
Fixes Permanent errors don't cause job failure #28