Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs should refer to Kubeflow user guide for deploying the TFJob operrator #412

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Docs should refer to Kubeflow user guide for deploying the TFJob operrator #412

merged 1 commit into from
Feb 27, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Feb 27, 2018 •
edited
Loading

  • Delete docs that explain how to use helm to deploy the TFJob CRD.
  • We don't have the resources to support and maintain helm packages.
  • We want to focus on just using ksonnet to deploy Kubeflow.

Fix #239

This change is Reviewable

@jlewi
Docs should refer to Kubeflow user guide for deploying the TFJob oper…
cd8533c 
…ator.

* We don't have the resources to support and maintain ksonnet and helm packages.
* We want to focus on just using ksonnet to deploy Kubeflow.
@jlewi jlewi requested a review from gaocegege February 27, 2018 04:13
gaocegege
gaocegege approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Feb 27, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 31.868% when pulling cd8533c on jlewi:helm_docs into c54cda9 on kubeflow:master.

@gaocegege
Copy link
Member

I think we could disable the coveralls comment function, it is useless for us.

@jlewi jlewi merged commit 0094aaa into kubeflow:master Feb 27, 2018
@gaocegege gaocegege mentioned this pull request Feb 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlewi @coveralls @gaocegege @k8s-ci-robot