Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller.go: Fix a glog typo #368

Merged
merged 1 commit into from
Feb 5, 2018
Merged

controller.go: Fix a glog typo #368

merged 1 commit into from
Feb 5, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Feb 3, 2018

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @gaocegege. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Feb 3, 2018

Coverage Status

Coverage remained the same at 31.856% when pulling 8aee482 on gaocegege:glog into 55058f2 on tensorflow:master.

@jlewi
Copy link
Contributor

jlewi commented Feb 4, 2018

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Feb 4, 2018

Please sync so that we rerun the tests using Argo.

@gaocegege
Copy link
Member Author

/test tf-k8s-presubmit

@gaocegege
Copy link
Member Author

PTAL, the test passed 😄

@jlewi jlewi merged commit 4220361 into kubeflow:master Feb 5, 2018
@gaocegege gaocegege deleted the glog branch February 5, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants