-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add copyright owner in go files #364
Conversation
Close #266 Signed-off-by: Ce Gao <[email protected]>
Hi @gaocegege. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please revise to Copyright The Kubeflow Authors, vs Google. |
I apologize for giving incorrect and misleading information about the author. |
@gaocegege thanks for your work on this! |
Signed-off-by: Ce Gao <[email protected]>
I have updated the owner to The Kubeflow Authors, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work!
For Copyright comments, I prefer to /* */
style rather than //
.
This is generated by google's tool: https://opensource.google.com/docs/releasing/preparing/#include-license-file-and-source-code-headers |
Close #266
Signed-off-by: Ce Gao [email protected]
This change is