Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: try to simplify e2e main.go #359

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jan 31, 2018

I'm trying to simplify main.go files but this would better be taking baby steps.

this very first step is to try to clean up spec.

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jimexist. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 31.746% when pulling 53e4b7f on Jimexist:simplify-main.go into 330eb92 on tensorflow:master.

@coveralls
Copy link

coveralls commented Jan 31, 2018

Coverage Status

Coverage remained the same at 31.746% when pulling 2720362 on Jimexist:simplify-main.go into 0de450f on tensorflow:master.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

Would be nice to update the PR description with a bit more detail.

@jlewi
Copy link
Contributor

jlewi commented Feb 2, 2018

/test all

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the pre-submit failed.

@jlewi
Copy link
Contributor

jlewi commented Feb 4, 2018

Please sync so that we rerun the tests using Argo. The presubmits should be much easier to debug if needed since logs should be publicly accessible via the Argo UI.

@jlewi
Copy link
Contributor

jlewi commented Feb 7, 2018

@jimexist Any chance you could sync? Would be great to get this committed?

@jimexist
Copy link
Member Author

jimexist commented Feb 8, 2018

@jlewi haven't been following closely recently, any docs on running Argo e2e test and ksonnet?

@jlewi
Copy link
Contributor

jlewi commented Feb 8, 2018

The tests are triggered automatically and they ran successfully.

All the information about our test infra (including debug info) is here:
https://github.com/kubeflow/testing

@jlewi jlewi merged commit 5557e87 into kubeflow:master Feb 8, 2018
@jimexist jimexist deleted the simplify-main.go branch February 9, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants