-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nit: try to simplify e2e main.go #359
Conversation
Hi @jimexist. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Would be nice to update the PR description with a bit more detail. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the pre-submit failed.
Please sync so that we rerun the tests using Argo. The presubmits should be much easier to debug if needed since logs should be publicly accessible via the Argo UI. |
@jimexist Any chance you could sync? Would be great to get this committed? |
@jlewi haven't been following closely recently, any docs on running Argo e2e test and ksonnet? |
The tests are triggered automatically and they ran successfully. All the information about our test infra (including debug info) is here: |
I'm trying to simplify
main.go
files but this would better be taking baby steps.this very first step is to try to clean up spec.
This change is