Fix helm test

[jose5918]

Helm test was failing because validation for a tfjob required that replicaSpecs for a Parameter server specify a template. Helm test failure also was not reported.

Changes made:

• Updated e2e tests and examples to include a template for the PS replicaSpec
• Check for None before concatenating the error.

Fixes #351 and #355

---

This change is 

[k8s-ci-robot]

Hi @jose5918. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikvadla]

@jose5918 Hey Jose, Can you please update the spec here too
https://github.com/tensorflow/k8s/blob/master/examples/tf_job.yaml#L24 (This will fix example-job)
https://github.com/tensorflow/k8s/blob/master/test/e2e/simple_job.yaml.template#L24 (Not sure whether we are using this template, but to make it consistent you can update here too)

[coveralls]

Coverage remained the same at 31.746% when pulling 1e10f2b on jose5918:helm_test into 7f97cf0 on tensorflow:master.

[jlewi]

Could you update the PR description to provide more info about what the problem was and the fix?

[jlewi]

use " not ' to be consistent with the rest of the file.

[jose5918]

@jlewi Sorry I don't follow. I don't see not in the rest of the file
Do you mean like an if else statement?

if not e:
  t.failure = "helm test failed;\n"
else:
  t.failure = "helm test failed;\n" + e.output

[jlewi]

I was referring to the quotation marks. We are using double quotes not single quotes in this file so we should be consistent.

[jose5918]

Ah got it

[jose5918]

@jlewi Ok this should be addressed

[jlewi]

/ok-to-test

[jlewi]

I confirmed the test is passing in Airflow.

[jlewi]

Thanks for the fix!
I'll merge this as soon as the tests finish running.