-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate IsDefaultPS in TFJob CRD API #343
Conversation
/test tf-k8s-presubmit |
Anybody else want to take a look? |
So this would mean that if the user does not specify a custom image for the PS, there would be no error thrown, and the default command for TensorFlow's base image would execute at runtime, so it would start a Jupyter notebook IIRC, since we don't have Did I miss something? If not, we should entirely remove the logic for default PS and force the user to specify a |
@wbuchwalter Thanks! Addressed your comments, PTAL. |
cb1534c
to
7864dc8
Compare
This PR fixes #329:
IsDefaultPS
in TFJob CRD APIhack/grpc_tensorflow_server/grpc_tensorflow_server.py
which is useless@jlewi @gaocegege @DjangoPeng PTAL.
This change is