-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: Fix the flag error caused by pflag #277
Conversation
Signed-off-by: Ce Gao <[email protected]>
Hi @gaocegege. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ce Gao <[email protected]>
/ok-to-test |
this changed lgtm, can you paste some log when use |
Of course
And if we want to print the logs in stderr, we need to add
|
PTAL |
/lgtm yes, i think we should set --logtostderr=true default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Close #275
Signed-off-by: Ce Gao [email protected]
This change is