Fix our continuous release process #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
reviewed
Jan 8, 2018
release/Dockerfile.release
Outdated
| @@ -45,7 +52,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
|
|
|||
| RUN easy_install pip | |||
| RUN pip install --upgrade six pyyaml google-api-python-client \ | |||
There was a problem hiding this comment.
suggest using Pipfile to lock down python dependencies
There was a problem hiding this comment.
I added a TODO. I tried to make it work but ran into problems. I'd rather get this PR submitted because it fixes our releases which is needed to get a Docker image out that works for the FE.
So I don't think its worth delaying to try to make pipenv work.
* We'd split release into two steps cloneing and building the code so we have to update the code.
jlewi
changed the title
|
Thanks @jimexist PTAL. |
|
@jimexist any additional comments? |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix our continuous release process which is broken (Fix the releaser so we can build new images #270)
Docker image used to build releases needs YARN and NodeJs to build the FE.
We refactored release.py and split cloning and building the code into two steps in Make cloning the repo and building the artifacts separate commands in py/release.py #189. So we had to refactor how we build from the latest green to account for these changes.
the code; We invoke the build function in the code checked out.
Our releaser has been crash looping and not released any new images since 12/23.
This change is