Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record event when tf_operator failover #260

Merged
merged 1 commit into from
Jan 3, 2018
Merged

record event when tf_operator failover #260

merged 1 commit into from
Jan 3, 2018

Conversation

zjj2wry
Copy link
Member

@zjj2wry zjj2wry commented Dec 30, 2017 •
edited by jlewi
Loading

we should use real event recorder, then we can get event from tf_operator endpoint when tf_operator failover

This change is Reviewable

@coveralls
Copy link

coveralls commented Dec 30, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 28.518% when pulling cf261ea on zjj2wry:event_record into ed7cae7 on tensorflow:master.

@zjj2wry zjj2wry mentioned this pull request Jan 2, 2018
Merged
@jlewi jlewi changed the title record event when rf_operator failover record event when tf_operator failover Jan 3, 2018
@jlewi
Copy link
Contributor

jlewi commented Jan 3, 2018

Can you pull in the latest changes from master? That should fix the travis build.

@coveralls
Copy link

coveralls commented Jan 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 28.458% when pulling 6ee6c62 on zjj2wry:event_record into 2793089 on tensorflow:master.

@zjj2wry
Copy link
Member Author

zjj2wry commented Jan 3, 2018

@jlewi of course, ready go～

@jlewi jlewi merged commit 2c8f325 into kubeflow:master Jan 3, 2018
@ghost ghost mentioned this pull request Jan 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjj2wry @coveralls @jlewi