Fix bugs in the release script. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Need to set GOPATH properly before building the code. * Copy the release scripts to the Docker image rather than cloning the repo. This makes it easier to push changes to the releaser because we can just build the image with local changes. Otherwise we need to commit the changes first and then build the Docker image.
* Add link to stackdriver logs for the releaser.
…re is no local repository.
* Add links to stackdriver. * Properly compute the GCS URI for the target in the latest .json file.
* Need to strip whitespace when comparing the SHAs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to set GOPATH properly before building the code.
Copy the release scripts to the Docker image rather than cloning the
repo. This makes it easier to push changes to the releaser because
we can just build the image with local changes. Otherwise we need to
commit the changes first and then build the Docker image.
Need to break out of the loop if only building once
Need to install helm in the releaser image because we use it to build the helm package.
Need to build the docker images using GCB so we don't need to access docker inside the pod running the releaser.
Store the image version in a json file inside the container and print out.
Related to Setup release process for CRD #63