Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test log should capture output from helm-test #95

Closed
jlewi opened this issue Oct 29, 2017 · 4 comments
Closed

E2E Test log should capture output from helm-test #95

jlewi opened this issue Oct 29, 2017 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 29, 2017

We should capture the output of helm-test in the build log created by runner.py.

Here's an example build log
).

The relevant lines are

Running: /go/bin/helm-test --image=gcr.io/mlkube-testing/tf_operator:v20171029-29b5d3e --output_dir=/tmp/tmpTfCrdTestHhjiY8 
cwd=None
Subprocess output:

helm-test failed; Command '['/go/bin/helm-test', u'--image=gcr.io/mlkube-testing/tf_operator:v20171029-29b5d3e', '--output_dir=/tmp/tmpTfCrdTestHhjiY8']' returned non-zero exit status 2
Running: ./lint.sh 

So no output is captured from helm test.

@jlewi
Copy link
Contributor Author

jlewi commented Oct 29, 2017

helm-test writes most of its output to the junit-01.xml file. There are some log statements at info level but those are probably missed because we haven't set the logging level to include them.

@jlewi
Copy link
Contributor Author

jlewi commented Oct 29, 2017

Here's the output, helm-test.output.txt, from running

~/go/bin/helm-test --image=gcr.io/mlkube-testing/tf_operator:v20171029-29b5d3e --output_dir=/tmp/tmpTfCrdTestHhjiY8 

So clearly we are missing a lot of output.

@jlewi
Copy link
Contributor Author

jlewi commented Oct 29, 2017

I think the problem is that helm-test ends up writing to stderr and the functions in util.py are only capturing output from stdout and not stderr.

@jlewi
Copy link
Contributor Author

jlewi commented Oct 29, 2017

This was fixed by #97

@jlewi jlewi closed this as completed Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant