Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy chart to kubernetes/charts #93

Closed
wbuchwalter opened this issue Oct 26, 2017 · 5 comments
Closed

Copy chart to kubernetes/charts #93

wbuchwalter opened this issue Oct 26, 2017 · 5 comments

Comments

@wbuchwalter
Copy link
Contributor

Once #71 is in, we should also make a PR to kubernetes/charts.
This would allow the installation of the chart by just doing
helm install incubator/tf-job which would be even simpler.

@jlewi
Copy link
Contributor

jlewi commented Oct 26, 2017

The problem with moving the chart to incubator/tf-job is that it would introduce a manual step into our release process. Any time we wanted to do a release we'd have to wait for a PR to be approved.

Eventually, I'd like to automate releases so that we push a new chart and Docker image on each green postsubmit.

Pushing to incubator/tf-job might make sense once we reach v1 or possible v1beta1 and things stabilize.

@bhack
Copy link

bhack commented Oct 26, 2017

Additionally charts are often out of sync partially cause by unresolved helm/charts#1471

@jlewi
Copy link
Contributor

jlewi commented Oct 26, 2017

@wbuchwalter Do you still think this is worth doing?

@wbuchwalter
Copy link
Contributor Author

Let's discuss it again once we are at a stable v1.
We won't be making as much breaking changes then, so it should be okay if the chart on kubernetes/charts is not updated as often.
Also hopefully helm/charts#1471 will have progressed.

@gaocegege
Copy link
Member

We do not support helm chart now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants