Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No results show up if you click on mlkube-build-periodic #76

Closed
jlewi opened this issue Oct 23, 2017 · 2 comments
Closed

No results show up if you click on mlkube-build-periodic #76

jlewi opened this issue Oct 23, 2017 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 23, 2017

If you click on periodic jobs in prow, we get the following internal service error

Traceback (most recent call last):
  File "/base/data/home/runtimes/python27_experiment/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 1535, in __call__
    rv = self.handle_exception(request, response, e)
  File "/base/data/home/runtimes/python27_experiment/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 1529, in __call__
    rv = self.router.dispatch(request, response)
  File "/base/data/home/runtimes/python27_experiment/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 1278, in default_dispatcher
    return route.handler_adapter(request, response)
  File "/base/data/home/runtimes/python27_experiment/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 1102, in __call__
    return handler.dispatch()
  File "/base/data/home/apps/s~k8s-gubernator/v20171019-c2170473.404922314496660020/view_base.py", line 56, in dispatch
    webapp2.RequestHandler.dispatch(self)
  File "/base/data/home/runtimes/python27_experiment/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 572, in dispatch
    return self.handle_exception(e, self.app.debug)
  File "/base/data/home/runtimes/python27_experiment/python27_lib/versions/third_party/webapp2-2.5.2/webapp2.py", line 570, in dispatch
    return method(*args, **kwargs)
  File "/base/data/home/apps/s~k8s-gubernator/v20171019-c2170473.404922314496660020/view_build.py", line 240, in get
    refs.append((x[1], ''))
IndexError: list index out of range
@jlewi
Copy link
Contributor Author

jlewi commented Oct 24, 2017

Look at the code in view_build.py

        refs = []
        if started and 'pull' in started:
            for ref in started['pull'].split(','):
                x = ref.split(':', 1)
                if len(x) == 2:
                    refs.append((x[0], x[1]))
                else:
                    refs.append((x[1], '')

If we look at started.json

gsutil cat gs://kubernetes-jenkins/logs/mlkube-build-periodic/32/started.json
{"timestamp": 1508781634, "repos": {"jlewi/mlkube.io": "a1d0405d0941f5b10addb7548f8a8a596a917472"}, "pull": ""}

So the problem appears to be that we shouldn't set the pull entry to the empty string in started.json

@jlewi jlewi closed this as completed in #77 Oct 24, 2017
jlewi added a commit that referenced this issue Oct 24, 2017
* GCS output for periodic jobs appears to be in kubernetes-jenkins/logs/mlkube-build-periodic
* Don't set PULL in started.json if its an empty string; this is causing the
  parse errors.
* Try to fix issue #76
@jlewi jlewi reopened this Oct 24, 2017
@jlewi
Copy link
Contributor Author

jlewi commented Oct 24, 2017

Still not fixed.

gsutil cat gs://kubernetes-jenkins/logs/mlkube-build-periodic/34/started.json
{"timestamp": 1508839343, "repos": {"jlewi/mlkube.io": "3e19cf5f9b58be5e5c537389e1ba9e1ed1120714"}, "pull": ""}

So "pull" is still there.

@jlewi jlewi closed this as completed in #78 Oct 24, 2017
jlewi added a commit that referenced this issue Oct 24, 2017
* Fix results for periodic test.

* We should only add "pull" if PULL_REFS is non-empty; there was a bug in
  previous commit.

* Add a unittest to ensure we correctly create started.json in the case of
periodic tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant