Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model exchange #709

Closed
bhack opened this issue Jul 1, 2018 · 12 comments
Closed

Model exchange #709

bhack opened this issue Jul 1, 2018 · 12 comments

Comments

@bhack
Copy link

bhack commented Jul 1, 2018

What is tf-operator and so Kubeflow position about model exchange between Kubeflow supported frameworks.
I open the issue here cause seems to me that the TF position is still not clearly resolved. See tensorflow/tensorflow#1288

@gaocegege
Copy link
Member

Do you mean the model is exchanged between tf, pytorch and so on?

@bhack
Copy link
Author

bhack commented Jul 1, 2018

Yes exactly to exchange models inside Kubeflow supported frameworks

@ddysher
Copy link
Member

ddysher commented Jul 2, 2018

@bhack what's ur use case for exchanging model between different frameworks? does https://github.com/onnx/onnx a viable solution to you? personally, i think it's out of scope for tf-operator.

@bhack
Copy link
Author

bhack commented Jul 2, 2018

@ddysher I think that the Google/TF position to not officially support onnx is particularly relavant for Kubeflow as it wants to be a cross framework tool. As I told I've opened the issue here cause pytorch-operator and mxnet operator suppport ONNX natively.

@bhack
Copy link
Author

bhack commented Jul 2, 2018

/cc @tjingrant

@jlewi
Copy link
Contributor

jlewi commented Jul 3, 2018

Kubeflow wants to be multi-framework but I don't know that we want to be cross framework. I think its perfectly fine if each framework has its own ecosystem and there isn't necessarily overlap between them (e.g. if you can't serve PyTorch using TFServing).

I think its really up to the different tools (e.g. onnx, TFServing) to determine whether they want to be cross framework or not.

Is there a lot of demand for model exchange? My assumption is that once you pick a framework (e.g. TF vs. PyTorch) most users are probably fine using tools within that ecosystem.

@bhack
Copy link
Author

bhack commented Jul 3, 2018

@jlewi Generally people want onnx cause they want to work with a single framework but as the model portfolio is not the same they want to us more model as possible without switching framework. I.e. have you seen the tensorRT approach to serving about models format support?

@jlewi
Copy link
Contributor

jlewi commented Jul 6, 2018

@bhack no haven't looked at TensorRT. Are you saying that people want onnx because they want to try out a bunch of different models and those models could be in different frameworks (e.g. TF vs. PyTorch)?

By framework are you referring to serving infrastructure in this case (e.g. model server as in onnx or tensorRT) as opposed to DL framework?

@bhack
Copy link
Author

bhack commented Jul 6, 2018

On the first point yes. Users can find published models related to paper authors that use different frameeorks or models engineered by different teams and they don't want to change framework just cause they want to use that specific model/research i.e. for fine-tuning.

On the serving side TensorRT 4 has onnx support but also Tensorflow. An example on how to run TensorRT inferencing service.

The specific things is that Onnx is not officially supported by Tensorflow but something is community maintained by @tjingrant IBM team

@tjingrant
Copy link

I do not have much to add since my experience with Kubeflow is limited, but it occurs to me that having an onnx-operator repository in kubeflow where users can specify backends might make more sense? Then users can just have onnx models in their model portfolio that are ready to be deployed to multiple backends for training(italicized b/c there's not much, [or maybe even a bit of reverse progress as they are removing training related flags], going on with supporting training in ONNX). This way it looks more like an issue suited for the ONNX spec group.

@gaocegege
Copy link
Member

gaocegege commented Sep 3, 2018

I think this issue is out of the scope of tf-operator. There are some candidates although:

@jlewi
Copy link
Contributor

jlewi commented Sep 3, 2018

I agree with @gaocegege.
Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants