Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1alpha2] Validate the TFJob converted from unstructured #682

Closed
gaocegege opened this issue Jun 16, 2018 · 2 comments
Closed

[v1alpha2] Validate the TFJob converted from unstructured #682

gaocegege opened this issue Jun 16, 2018 · 2 comments
Labels
api/v1alpha2 area/0.3.0 kind/feature

Comments

@gaocegege
Copy link
Member

#678 has a simple check. We need a more detailed one.
@jiaxuanzhou
Copy link
Contributor

this kind of validation should be implemented in pkg/apis/validation

@gaocegege
Copy link
Member Author

Yeah, thanks for your suggestion. I think so.

@gaocegege gaocegege changed the title [v1alpha2] Validate the TFJob converted from unstructured is valid. [v1alpha2] Validate the TFJob converted from unstructured Jun 20, 2018
@codeflitting codeflitting mentioned this issue Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api/v1alpha2 area/0.3.0 kind/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ankushagarwal @gaocegege @jiaxuanzhou