Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep ensure give warning on k8s.io/apiserver #647

Closed
xychu opened this issue Jun 13, 2018 · 4 comments
Closed

dep ensure give warning on k8s.io/apiserver #647

xychu opened this issue Jun 13, 2018 · 4 comments

Comments

@xychu
Copy link
Contributor

xychu commented Jun 13, 2018

When I run dep ensure as Developer Guide suggested,

I got:

Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml:

  ✗  k8s.io/apiserver

However, these projects are not direct dependencies of the current project:
they are not imported in any .go files, nor are they in the 'required' list in
Gopkg.toml. Dep only applies [[constraint]] rules to direct dependencies, so
these rules will have no effect.

Either import/require packages from these projects so that they become direct
dependencies, or convert each [[constraint]] to an [[override]] to enforce rules
on these projects, if they happen to be transitive dependencies,

And as a result, lots of extra pkgs got added into vendor/ directory.

Is this expected?

@gaocegege
Copy link
Member

Are you running it in the latest master? And could you please have a try on dep ensure -v?

@gaocegege
Copy link
Member

I can not reproduce it.

@xychu
Copy link
Contributor Author

xychu commented Jun 13, 2018

@gaocegege same warn for the latest master.

BTW, my go version is 1.10.3 and dep version is v0.4.1.

I've tried go build without those extra pkgs added by dep ensure and it works well.
So it's not a issue, feel free to close it :-)

@gaocegege
Copy link
Member

Thanks, we have some tools to generate clientsets, thus we use required to import them. But I am not sure if the deps will import apiserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants