Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1alpha2] Try to not to always claim pods #533

Closed
gaocegege opened this issue Apr 12, 2018 · 2 comments
Closed

[v1alpha2] Try to not to always claim pods #533

gaocegege opened this issue Apr 12, 2018 · 2 comments

Comments

@gaocegege
Copy link
Member

#526 (comment)

@ddysher
Copy link
Member

ddysher commented Apr 12, 2018

My original thought is to rename the function to better capture its intent (get and claim). This is just for clarity, and I do think it's necessary to patch the pods in each controller iteration: reconciliation is the reason we need controller (i hope there is optimization in apiserver side to not actually update the backend if data doesn't change).

If that's how kubernetes upstream controller name the function, let's just stick with it (even if i think it's a bad name :). naming is hard anyway

@gaocegege
Copy link
Member Author

I agree, thus closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants