Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about example TFJob YAML specs? #375

Closed
jlewi opened this issue Feb 7, 2018 · 5 comments
Closed

What to do about example TFJob YAML specs? #375

jlewi opened this issue Feb 7, 2018 · 5 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 7, 2018

We currently have some example YAML specs here.

@gaocegege
Copy link
Member

I think some examples are outdated and we should remove them. Actually I think we have no enough contributors to maintain multiple examples. Maybe one is enough.

@wbuchwalter
Copy link
Contributor

wbuchwalter commented Mar 1, 2018

Also, this examples won't necessary work on all clusters. For example tf_job_gpu.yaml can only run on cluster with NVIDIA device plugin installed, and won't run on clusters still using alpha.kubernetes.io/nvidia-gpu resource such as Azure.

So we could either:

  • Use ksonnet to parametrize this with a cloud param.
  • Create different directories for different environments.

I like the second option for two reasons:

  • I think examples should be very easy to read, and IMHO a simple yaml file is much easier to read/understand than a ksonnet templates.
  • This would allow for environment specific examples, such as using Azure Files to save checkpoints on Azure, using S3 on AWS etc.

However like @gaocegege mentioned, this is more work.

@jlewi jlewi removed this from the Kubecon Europe milestone Jun 11, 2018
@lovejoy
Copy link
Contributor

lovejoy commented Aug 10, 2018

https://github.com/kubeflow/tf-operator/tree/master/examples/crd https://github.com/kubeflow/tf-operator/tree/master/examples/v1alpha2/dist-mnist are useful. And I think there are many people don't use ksonnet. So it is better if there are some example yaml file.

@jlewi
Copy link
Contributor Author

jlewi commented Sep 3, 2018

True; but we could use ks show to automatically publish our ksonnet examples as YAMl manifests. The advantage of doing it that way is

  1. We have E2E tests for our ksonnet prototypes
  2. Those ksonnet prototypes are kept up to date.

@stale
Copy link

stale bot commented Apr 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants