Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default TfImage configurable by users #207

Closed
cwbeitel opened this issue Dec 8, 2017 · 2 comments
Closed

Make default TfImage configurable by users #207

cwbeitel opened this issue Dec 8, 2017 · 2 comments
Labels
good first issue kind/enhancement

Comments

@cwbeitel
Copy link
Contributor

cwbeitel commented Dec 8, 2017

Parameter servers and tensorboard instances deployed by the tfJob operator currently run tensorflow/tensorflow:1.3.0 by default. Customizing this at job time is possible by adding a tfImage: field to the job spec, e.g.

kind: "TfJob"
...
spec:
  ...
  tfImage: tensorflow/tensorflow:1.4.0

Users may prefer to configure the default tensorflow container at deploy- instead of job-time.

The proposed change is to allow the default image to be specified in the chart values.yaml permitting easy customization at deploy-time, such as with the following:

helm install ${CHART} -n tf-job --wait --replace \
  --set tfimage=tensorflow/tensorflow:1.4.0,...
@zjj2wry
Copy link
Member

zjj2wry commented Dec 13, 2017

anyone in process with this issue? if not, i 'd like pick this for my first issue.

@cwbeitel
Copy link
Contributor Author

Go for it!

@zjj2wry zjj2wry mentioned this issue Dec 14, 2017
Merged
jlewi pushed a commit that referenced this issue Dec 20, 2017
@jlewi
let tfJob image configurable be configurable via the controller config(…
6d0455e 
…#228)

* Fixes #207

* test: add test for setDefault func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @cwbeitel @zjj2wry