You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This causes problems if the config_file doesn't actually exist which is the case if the user doesn't specify the cloud flag when installing the helm chart. I suspect this is the problem in #149 and #173.
We should modify the helm chart so that controller_config_file is only set if a config map is specified.
The text was updated successfully, but these errors were encountered:
How about setting an empty configmap by default? Please take a look at the patch. If we prepare the empty configmap, it's easy for users to specify something individual based on the updated config.yaml. If they don't specify anything, helm install successfully as well.
@DjangoPeng can you review #176 please? What's the advantage of providing an empty config map as opposed to just not providing a config map and setting the flags accordingly.
With #176 if a user wants to specify a custom map then they can do something like this
Our helm chart currently always sets controller_config_file
This causes problems if the config_file doesn't actually exist which is the case if the user doesn't specify the cloud flag when installing the helm chart. I suspect this is the problem in #149 and #173.
We should modify the helm chart so that controller_config_file is only set if a config map is specified.
The text was updated successfully, but these errors were encountered: