Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gang schedule annotation #1031

Closed
zlcnju opened this issue Jun 21, 2019 · 2 comments · Fixed by #1032
Closed

gang schedule annotation #1031

zlcnju opened this issue Jun 21, 2019 · 2 comments · Fixed by #1032

Comments

@zlcnju
Copy link
Contributor

zlcnju commented Jun 21, 2019

The annotation is need to be set when use gang scheduler as described. However, now the podgroup is created by tf operator, but the annotation is not set auto. So, i think it's better to add annotation auto as the scheduler name when gang-scheduling is enabled.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.81. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ChanYiLin
Copy link
Member

Thanks for the issue!

I have sent a PR to fix the issue, #1032 .
BTW, we create the podGroup with the same name as the tfJob not scheduler name. So the annotation should be scheduling.k8s.io/group-name: $PODGROUP_NAME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants