Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run E2E tests selectively based on modified source files #150

Closed
jlewi opened this issue Jun 6, 2018 · 3 comments
Closed

Run E2E tests selectively based on modified source files #150

jlewi opened this issue Jun 6, 2018 · 3 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 6, 2018

I think we'd like to be able to trigger certain E2E workflows only when certain files are changed.

Example, if we have an E2E test for TFServing, we should only need to run that in presubmit/postsubmits if a subset of code actually changed.

One proposal is in prow_config.xml, for every workflow we could specify include/exclude expressions and we would only run a test if the files modified matched that expression.

I think this will become important as we add more tests.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 6, 2018

Bumping to P1 because test flakes are becoming a major headache. Being able to selectively run tests should help.

I think we can do something like add includes and excludes sections to each workflow in prow_config.yaml. These could be regexes or globs used to match paths.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 9, 2018

@richardsliu Any interest in taking a stab at this?

@richardsliu
Copy link
Contributor

Sure, I can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants