Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a standard Argo workflow to run basic tests #11

Closed
jlewi opened this issue Feb 5, 2018 · 5 comments
Closed

Create a standard Argo workflow to run basic tests #11

jlewi opened this issue Feb 5, 2018 · 5 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 5, 2018

  • We should create a standard workflow to run basic tests that can be shared by all our repositories; eg

    • lint checks
    • run py and go unittests
  • I think its an open question whether we would run this as a separate prow job or have a single prow job for each workflow and run this as a sub workflow.

@jlewi
Copy link
Contributor Author

jlewi commented Feb 16, 2018

#33 added a workflow to kubeflow/testing to run python unittests and lint.

We've also added the ability to run multiple workflows specified via prow_config.yaml.

So I think turning the test in kubeflow/testing into a reusable workflow that any repo can use is a good place to start.

I think the main changes we would need to make are modifying py_checks so that we can take as arguments the src directory to search for python files and also any exclude directories.

This will probably mean that we want to extend our infrastructure for running Argo workflows from prow jobs so that we can specify ksonnet parameters in our prow_config YAML files.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 29, 2019

We should try to do this in 0.6.

@jlewi
Copy link
Contributor Author

jlewi commented Apr 16, 2019

@stale
Copy link

stale bot commented Jul 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Aug 1, 2019

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant