Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

v1alpha2 pytorch API should try to be consistent with TFJob #49

Closed
jlewi opened this issue Jul 3, 2018 · 2 comments
Closed

v1alpha2 pytorch API should try to be consistent with TFJob #49

jlewi opened this issue Jul 3, 2018 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 3, 2018

TFJob operator v1alpha2 made a bunch of API changes e.g

  • Use dictionary for replicas not list
  • Introduced CleanPodPolicy

We should create a v1alpha2 API for PyTorch that strives to be as consistent with TFJob as possible.

@jlewi
Copy link
Contributor Author

jlewi commented Aug 21, 2018

@johnugeorge How's this coming? Looks like the PR kubeflow/training-operator#786 creates a v1alpha2 API for PyTorch that is consistent with TFJob v1alpha2.

@johnugeorge
Copy link
Member

Yes. You are right. The confusion is only wrt to location where to keep the code. I tested v1 alpha2 code with a basic example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants