From 3dcc3776cb1247b8fe8b35d80db0bd885291d837 Mon Sep 17 00:00:00 2001 From: Yaqi Date: Wed, 6 Oct 2021 11:13:23 -0700 Subject: [PATCH 1/3] feat(sdk): add placeholder variables --- sdk/python/kfp/v2/dsl/__init__.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sdk/python/kfp/v2/dsl/__init__.py b/sdk/python/kfp/v2/dsl/__init__.py index 6a1bebf7dd7..6ca1967de13 100644 --- a/sdk/python/kfp/v2/dsl/__init__.py +++ b/sdk/python/kfp/v2/dsl/__init__.py @@ -42,3 +42,11 @@ ExitHandler, ParallelFor, ) + +PIPELINE_JOB_NAME_PLACEHOLDER = '{{$.pipeline_job_name}}' +PIPELINE_JOB_RESOURCE_NAME_PLACEHOLDER = '{{$.pipeline_job_resource_name}}' +PIPELINE_JOB_ID_PLACEHOLDER = '{{$.pipeline_job_uuid}}' +# RUN_ID_PLACEHOLDER is deprecated. +RUN_ID_PLACEHOLDER = '{{$.pipeline_job_uuid}}' +PIPELINE_TASK_NAME_PLACEHOLDER = '{{$.pipeline_task_name}}' +PIPELINE_TASK_ID_PLACEHOLDER = '{{$.pipeline_task_uuid}}' \ No newline at end of file From 1cb386c9b036c36495e33428989f80cb3d8a9911 Mon Sep 17 00:00:00 2001 From: Yaqi Date: Wed, 6 Oct 2021 11:19:49 -0700 Subject: [PATCH 2/3] add release notes --- sdk/RELEASE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/RELEASE.md b/sdk/RELEASE.md index 3018a2e86d9..84ccd3673fa 100644 --- a/sdk/RELEASE.md +++ b/sdk/RELEASE.md @@ -2,6 +2,8 @@ ## Major Features and Improvements +* Add placeholder variables [\#6693](https://github.com/kubeflow/pipelines/pull/6693) + ## Breaking Changes ### For Pipeline Authors From 3c1dae7707d793ad4fd2631864a8285f7d0b5d99 Mon Sep 17 00:00:00 2001 From: Yaqi Date: Wed, 6 Oct 2021 13:23:42 -0700 Subject: [PATCH 3/3] address comments --- sdk/RELEASE.md | 2 +- sdk/python/kfp/v2/dsl/__init__.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/sdk/RELEASE.md b/sdk/RELEASE.md index 84ccd3673fa..a89652ed4c8 100644 --- a/sdk/RELEASE.md +++ b/sdk/RELEASE.md @@ -2,7 +2,7 @@ ## Major Features and Improvements -* Add placeholder variables [\#6693](https://github.com/kubeflow/pipelines/pull/6693) +* Add v2 placeholder variables [\#6693](https://github.com/kubeflow/pipelines/pull/6693) ## Breaking Changes diff --git a/sdk/python/kfp/v2/dsl/__init__.py b/sdk/python/kfp/v2/dsl/__init__.py index 6ca1967de13..5dfc3958639 100644 --- a/sdk/python/kfp/v2/dsl/__init__.py +++ b/sdk/python/kfp/v2/dsl/__init__.py @@ -46,7 +46,5 @@ PIPELINE_JOB_NAME_PLACEHOLDER = '{{$.pipeline_job_name}}' PIPELINE_JOB_RESOURCE_NAME_PLACEHOLDER = '{{$.pipeline_job_resource_name}}' PIPELINE_JOB_ID_PLACEHOLDER = '{{$.pipeline_job_uuid}}' -# RUN_ID_PLACEHOLDER is deprecated. -RUN_ID_PLACEHOLDER = '{{$.pipeline_job_uuid}}' PIPELINE_TASK_NAME_PLACEHOLDER = '{{$.pipeline_task_name}}' PIPELINE_TASK_ID_PLACEHOLDER = '{{$.pipeline_task_uuid}}' \ No newline at end of file