From e8c513db76435dda8b757e0f8d5d3646ca58bdb9 Mon Sep 17 00:00:00 2001 From: Lin Yiming Date: Thu, 23 Sep 2021 18:20:02 +0800 Subject: [PATCH 1/2] fix(sdk): sanitize op name. Fix #6433 --- sdk/python/kfp/dsl/_pipeline.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/python/kfp/dsl/_pipeline.py b/sdk/python/kfp/dsl/_pipeline.py index d8368780520..e34b348e759 100644 --- a/sdk/python/kfp/dsl/_pipeline.py +++ b/sdk/python/kfp/dsl/_pipeline.py @@ -331,10 +331,10 @@ def add_op(self, op: _container_op.BaseOp, define_only: bool): '_', '-') #If there is an existing op with this name then generate a new name. op_name = _naming._make_name_unique_by_adding_index( - op_name, list(self.ops.keys()), ' ') + op_name, list(self.ops.keys()), '-') if op_name == '': op_name = _naming._make_name_unique_by_adding_index( - 'task', list(self.ops.keys()), ' ') + 'task', list(self.ops.keys()), '-') self.ops[op_name] = op if not define_only: From 54b570dab100dccc00995272d23888937c00cb13 Mon Sep 17 00:00:00 2001 From: Lin Yiming Date: Tue, 28 Sep 2021 14:24:06 +0800 Subject: [PATCH 2/2] Add release note: Fix the error that kfp v1 compiler failed to provide unique name for ops of the same component. --- sdk/RELEASE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/RELEASE.md b/sdk/RELEASE.md index f5f80a8d323..e54b77d7ed3 100644 --- a/sdk/RELEASE.md +++ b/sdk/RELEASE.md @@ -13,6 +13,7 @@ ## Bug Fixes and Other Changes * Fix duplicate function for `list_pipeline_versions()`. [\#6594](https://github.com/kubeflow/pipelines/pull/6594) * Support re-use of PVC with VolumeOp. [\#6582](https://github.com/kubeflow/pipelines/pull/6582) +* Fix the error that kfp v1 compiler failed to provide unique name for ops of the same component. [\#6600](https://github.com/kubeflow/pipelines/pull/6600) ## Documentation Updates # 1.8.2