Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update kustomize manifests to be kustomize v3 compatible #4785

Closed
wants to merge 1 commit into from

Conversation

dfarr
Copy link

@dfarr dfarr commented Nov 19, 2020

Description of your changes:

Update kustomize manifests to be kustomize v3 compatible. Included changes:

  1. bases -> resources (bases is deprecated)
  2. env -> envs in configMapGenerator and secretGenerator

Checklist:

@google-cla
Copy link

google-cla bot commented Nov 19, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfarr
To complete the pull request process, please assign ironpan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @dfarr. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dfarr
Copy link
Author

dfarr commented Nov 19, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 19, 2020
@Bobgy Bobgy self-assigned this Nov 23, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Nov 23, 2020

Hi @dfarr! We haven't decided to drop kubectl apply -k support, so we won't be accepting this PR.
If you want to consume kfp by kustomize v3, you can fix the syntax after pulling the manifest.

For example: https://github.com/kubeflow/manifests/blob/4e004e50fa6221f78292a7298dc0507ec6af829c/hack/pull_kfp_upstream.sh#L22-L27

@Bobgy Bobgy closed this Nov 23, 2020
@dfarr
Copy link
Author

dfarr commented Nov 23, 2020

Got it thanks, hopefully the version of kustomize shipped with kubectl is updated soon. This seems to be the PR tracking that progress.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 24, 2020

Thanks, I'd hope so too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants