Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk/backend): allow using cluster's default sc #11417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leseb
Copy link
Contributor

@leseb leseb commented Nov 28, 2024

Description of your changes:

728c24f fix(sdk/backend): allow using cluster's default sc

commit 728c24f
Author: Sébastien Han [email protected]
Date: Wed Nov 27 16:52:09 2024 +0100

fix(sdk/backend): allow using cluster's default sc

When using the SDK's function `CreatePVC`, leaving the
`storage_class_name` field empty will result in the cluster’s default
storage class being applied.

To enhance modularity and clarity, the logic for building the PVC
definition has been refactored into a dedicated function. Error messages
have been updated to align with this change, and unit tests have been
implemented to cover all required and optional fields.

In the code handling annotations, the `GetFields` method has replaced
the use of the `AsMap` method. This approach is more convenient and
eliminates the need for type conversion to `structpb.Value`.

Resolves: #11396
Signed-off-by: Sébastien Han <[email protected]>

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @leseb. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

When using the SDK's function `CreatePVC`, leaving the
`storage_class_name` field empty will result in the cluster’s default
storage class being applied.

To enhance modularity and clarity, the logic for building the PVC
definition has been refactored into a dedicated function. Error messages
have been updated to align with this change, and unit tests have been
implemented to cover all required and optional fields.

In the code handling annotations, the `GetFields` method has replaced
the use of the `AsMap` method. This approach is more convenient and
eliminates the need for type conversion to `structpb.Value`.

Resolves: kubeflow#11396
Signed-off-by: Sébastien Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant