Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): use GetResourceType and GetResourceCount. Fixes #11375. #11409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahdikhashan
Copy link

@mahdikhashan mahdikhashan commented Nov 26, 2024

Description of your changes:

This PR fixes #11375.

I have updated the pipeline package to use the latest commit from the master. Then I replaced the GetCount with GetResourceCount and GetType with GetResourceType.

Checklist:

…ated GetType and GetCount

Signed-off-by: mahdikhashan <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @mahdikhashan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mahdikhashan
Copy link
Author

there are two todo comment in the changes. If I could change the return type of GetResourceCount to int (like GetCount) to be an int, I dont need to convert it in the code. Do you agree with changing it? However, I have not checked the reason for it being string in the code. (the comments will be removed, fixed after your input)

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I could change the return type of GetResourceCount to int (like GetCount) to be an int, I dont need to convert it in the code. Do you agree with changing it?

@mahdikhashan sounds reasonable to me. But I also don't know if there's a good reason for that being created as string.
Probably @chensun can give us a safe answer.

@mahdikhashan can you please link the PR to the issue?
Also, the CI is failing.

@hbelmiro
Copy link
Contributor

/ok-to-test

@mahdikhashan
Copy link
Author

mahdikhashan commented Nov 27, 2024

thanks @hbelmiro for your input and review. I'm not sure I have the right access to link the issue to this pr (nor I wasnt able to link pr to the issue as well)

I'll fix the CI, thanks for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(backend): use non deprecated accelerator type & count fields in driver
2 participants