-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(backend): use GetResourceType and GetResourceCount. Fixes #11375. #11409
base: master
Are you sure you want to change the base?
Conversation
…ated GetType and GetCount Signed-off-by: mahdikhashan <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mahdikhashan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
there are two todo comment in the changes. If I could change the return type of GetResourceCount to int (like GetCount) to be an int, I dont need to convert it in the code. Do you agree with changing it? However, I have not checked the reason for it being string in the code. (the comments will be removed, fixed after your input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I could change the return type of GetResourceCount to int (like GetCount) to be an int, I dont need to convert it in the code. Do you agree with changing it?
@mahdikhashan sounds reasonable to me. But I also don't know if there's a good reason for that being created as string
.
Probably @chensun can give us a safe answer.
@mahdikhashan can you please link the PR to the issue?
Also, the CI is failing.
/ok-to-test |
I'll fix the CI, thanks for your input. |
Description of your changes:
This PR fixes #11375.
I have updated the pipeline package to use the latest commit from the master. Then I replaced the GetCount with GetResourceCount and GetType with GetResourceType.
Checklist: